server: Fix flaky TestServerPathEncodingIssues tests #10356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set getNumHomes: 1 to enable 567 ms or 2 s of wait for the server to be ready in TestServerPathEncodingIssues/Unicode_paths and TestServerPathEncodingIssues/Windows_multilingual_404. Fixes gohugoio#10332
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
getNumHomes: 1to enable the 567 ms or 2 seconds of wait for the server to be ready inTestServerPathEncodingIssues/Unicode_pathsandTestServerPathEncodingIssues/Windows_multilingual_404.Fixes #10332
Hi @bep, I hope this is the right fix. Besides waiting for the GitHub Actions CI test result, I'll be uploading 0.104.2-2 to Debian shortly and will report back if these tests pass the very first time on all architectures.